Archive/opengoal-launcher
1
0
Fork 0
mirror of https://github.com/open-goal/launcher.git synced 2024-10-19 14:47:36 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

versions: remove launcher version check (#555)
Some checks failed
🔨 Build / App (macos-12) (push) Has been cancelled
Details
🔨 Build / App (ubuntu-20.04) (push) Has been cancelled
Details
🔨 Build / App (windows-latest) (push) Has been cancelled
Details
📝 Linter / Frontend (push) Has been cancelled
Details
📝 Linter / Backend Formatting (push) Has been cancelled
Details
📝 Linter / Backend Linter (push) Has been cancelled
Details
🧪 Tests / Frontend (push) Has been cancelled
Details

Browse source 
For posterity, 0.2.0 required atleast launcher 2.3.3

Fixes #369 

Upon reflection, this is likely overkill as the check hasn't been
properly maintained for over a year and there's been no related issues.
Just remove it
This commit is contained in:
Tyler Wilding 2024-09-08 01:49:13 -04:00 committed by GitHub
parent 7c9de0ab39
commit 3097796b3f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/lib/utils/github.ts
View file

@ -93,20 +93,8 @@ async function parseGithubRelease(githubRelease: any): Promise<ReleaseInfo> {
// do nothing, bad formatting
releaseInfo.invalidationReasons = ["Release invalid for unknown reasons"];
}
} else if (githubRelease.body.includes("<!-- requires-launcher-version:")) {
// Check the current semver and compare
const launcherVersion = await getVersion();
const requiredMinimumVersion = githubRelease.body
.split("<!-- requires-launcher-version:")[1]
.split("-->")[0]
.trim();
if (!semver.gte(launcherVersion, requiredMinimumVersion)) {
releaseInfo.invalid = true;
releaseInfo.invalidationReasons = [
`This version requires the launcher to be updated to atleast: ${requiredMinimumVersion}`,
];
}
}
return releaseInfo;
}