mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-10-24 12:10:33 -04:00
bbb2f93cee
Unless dontWrapGapps is set, the wrap-gapps-hook.sh will currently wrap all executables (and symbolic links to executables) found under the target directories: bin and libexec. As a result, if a symbolic link in a target directory points to an executable in a target directory, both will get wrapped. This causes an extra shell/exec when following the symbolic link, as well as increasing the size of the final executable's environment. To avoid wrapping a link to an already wrapped executable, this commit splits the determination of what gets wrapped into two phases: 1. All binaries under the target directories are wrapped and logged with "Wrapping program ..." 2. All links to executables under the target directories are identified and checked to see if they reference an executable under one of the target directories. If yes, the required wrapping has already been performed on the associated binary (in phase 1), so no wrapping is done and "Not wrapping link: ... (already wrapped)" is logged. If no, the link points at an executable that hasn't been wrapped, so the link is wrapped and "Wrapping link: ..." is logged. As an example, the yelp package has a bin directory that contains an executable "yelp" and a symbolic link "gnome-help" -> "yelp". Prior to this commit, the bin directory would contain these files after wrapping: gnome-help -- wrapper to exec .gnome-help-wrapped .gnome-help-wrapped -- a symbolic link to yelp yelp -- wrapper to exec .yelp-wrapped .yelp-wrapped -- the original yelp binary After this commit, the bin directory will instead contain: gnome-help -- a symbolic link to yelp yelp -- wrapper to exec .yelp-wrapped .yelp-wrapped -- the original yelp binary NOTE: The primary motivation for this commit is to avoid obscuring the fact that two or more paths are simple aliases and expected to behave identically. It also reduces the likelihood of hitting limits related to environment variable size. LIMITATION: The method used above is intended to be conservative and will still wrap symbolic links to other symbolic links when the ultimate target is outside of bin or libexec. |
||
|---|---|---|
| .. | ||
| audit-tmpdir.sh | ||
| auto-patchelf.sh | ||
| autoreconf.sh | ||
| breakpoint-hook.sh | ||
| compress-man-pages.sh | ||
| die.sh | ||
| enable-coverage-instrumentation.sh | ||
| find-xml-catalogs.sh | ||
| fix-darwin-dylib-names.sh | ||
| gog-unpack.sh | ||
| keep-build-tree.sh | ||
| ld-is-cc-hook.sh | ||
| make-coverage-analysis-report.sh | ||
| make-wrapper.sh | ||
| move-docs.sh | ||
| move-lib64.sh | ||
| move-sbin.sh | ||
| multiple-outputs.sh | ||
| patch-shebangs.sh | ||
| prune-libtool-files.sh | ||
| role.bash | ||
| separate-debug-info.sh | ||
| set-java-classpath.sh | ||
| set-source-date-epoch-to-latest.sh | ||
| setup-debug-info-dirs.sh | ||
| strip.sh | ||
| update-autotools-gnu-config-scripts.sh | ||
| use-old-cxx-abi.sh | ||
| win-dll-link.sh | ||
| wrap-gapps-hook.sh | ||