mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-10-22 11:54:30 -04:00
bedc267a78
This commit fixes precise dependency ignorance by converting the
environment variable `autoPatchelfIgnoreMissingDeps` into a bash array
`ignoreMissingDepsArray`, passing `"${ignoreMissingDepsArray[@]}"`
instead of `"${autoPatchelfIgnoreMissingDeps[@]}"` to the python
script.
The original implementation does not work when
`autoPatchelfIgnoreMissingDeps` contains multiple dependency names.
Because it mistakenly passes `"${autoPatchelfIgnoreMissingDeps[@]}"`
to the python script. According to the Nix manual
(https://nixos.org/manual/nix/stable/expressions/derivations.html),
lists of strings are concatenated into whitespace-separated strings,
then passed to the builder as environment variables. So, if
`autoPatchelfIgnoreMissingDeps = [ "dep1" "dep2" "dep3" ]`,
`"${autoPatchelfIgnoreMissingDeps[@]}"` will be expanded to a single
argument `"dep1 dep2 dep3"`, which is not the intended behavior,
because the python script takes the long argument as a dependency
name.
With this commit, `"${ignoreMissingDepsArray[@]}"` will be expanded to
three arguments `"dep1" "dep2" "dep3"` arguments as expected, fixing
the issue.
|
||
|---|---|---|
| .. | ||
| wrap-gapps-hook | ||
| audit-blas.sh | ||
| audit-tmpdir.sh | ||
| auto-patchelf.py | ||
| auto-patchelf.sh | ||
| autoreconf.sh | ||
| breakpoint-hook.sh | ||
| canonicalize-jars.sh | ||
| compress-man-pages.sh | ||
| copy-desktop-items.sh | ||
| desktop-to-darwin-bundle.sh | ||
| die.sh | ||
| enable-coverage-instrumentation.sh | ||
| find-xml-catalogs.sh | ||
| fix-darwin-dylib-names.sh | ||
| gog-unpack.sh | ||
| install-shell-files.sh | ||
| keep-build-tree.sh | ||
| ld-is-cc-hook.sh | ||
| make-binary-wrapper.sh | ||
| make-coverage-analysis-report.sh | ||
| make-symlinks-relative.sh | ||
| make-wrapper.sh | ||
| move-docs.sh | ||
| move-lib64.sh | ||
| move-sbin.sh | ||
| move-systemd-user-units.sh | ||
| multiple-outputs.sh | ||
| patch-shebangs.sh | ||
| prune-libtool-files.sh | ||
| reproducible-builds.sh | ||
| role.bash | ||
| separate-debug-info.sh | ||
| set-java-classpath.sh | ||
| set-source-date-epoch-to-latest.sh | ||
| setup-debug-info-dirs.sh | ||
| shorten-perl-shebang.sh | ||
| strip.sh | ||
| update-autotools-gnu-config-scripts.sh | ||
| use-old-cxx-abi.sh | ||
| validate-pkg-config.sh | ||
| win-dll-link.sh | ||