mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-10-20 11:11:43 -04:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
179 lines
4.3 KiB
Nix
179 lines
4.3 KiB
Nix
{ lib
|
|
, stdenv
|
|
, fetchurl
|
|
, fetchFromGitLab
|
|
, fetchpatch
|
|
, cairo
|
|
, cmake
|
|
, boost
|
|
, curl
|
|
, fontconfig
|
|
, freetype
|
|
, lcms
|
|
, libiconv
|
|
, libintl
|
|
, libjpeg
|
|
, ninja
|
|
, openjpeg
|
|
, pkg-config
|
|
, python3
|
|
, zlib
|
|
, withData ? true, poppler_data
|
|
, qt5Support ? false, qt6Support ? false, qtbase ? null
|
|
, introspectionSupport ? false, gobject-introspection ? null
|
|
, gpgmeSupport ? false, gpgme ? null
|
|
, utils ? false, nss ? null
|
|
, minimal ? false
|
|
, suffix ? "glib"
|
|
|
|
# for passthru.tests
|
|
, cups-filters
|
|
, gdal
|
|
, gegl
|
|
, inkscape
|
|
, pdfslicer
|
|
, scribus
|
|
, vips
|
|
}:
|
|
|
|
let
|
|
mkFlag = optset: flag: "-DENABLE_${flag}=${if optset then "on" else "off"}";
|
|
|
|
# unclear relationship between test data repo versions and poppler
|
|
# versions, though files don't appear to be updated after they're
|
|
# added, so it's probably safe to just always use the latest available
|
|
# version.
|
|
testData = fetchFromGitLab {
|
|
domain = "gitlab.freedesktop.org";
|
|
owner = "poppler";
|
|
repo = "test";
|
|
rev = "400f3ff05b2b1c0ae17797a0bd50e75e35c1f1b1";
|
|
hash = "sha256-Y4aNOJLqo4g6tTW6TAb60jAWtBhRgT/JXsub12vi3aU=";
|
|
};
|
|
in
|
|
stdenv.mkDerivation (finalAttrs: rec {
|
|
pname = "poppler-${suffix}";
|
|
version = "24.02.0"; # beware: updates often break cups-filters build, check scribus too!
|
|
|
|
outputs = [ "out" "dev" ];
|
|
|
|
src = fetchurl {
|
|
url = "https://poppler.freedesktop.org/poppler-${version}.tar.xz";
|
|
hash = "sha256-GRh6P90F8z59YExHmcGD3lygEYZAyIs3DdzzE2NDIi4=";
|
|
};
|
|
|
|
patches = [
|
|
(fetchpatch {
|
|
# https://access.redhat.com/security/cve/CVE-2024-6239
|
|
name = "CVE-2024-6239.patch";
|
|
url = "https://gitlab.freedesktop.org/poppler/poppler/-/commit/0554731052d1a97745cb179ab0d45620589dd9c4.patch";
|
|
hash = "sha256-I78wJ4l1DSh+x/e00ZL8uvrGdBH+ufp+EDm0A1XWyCU=";
|
|
})
|
|
];
|
|
|
|
nativeBuildInputs = [
|
|
cmake
|
|
ninja
|
|
pkg-config
|
|
python3
|
|
];
|
|
|
|
buildInputs = [
|
|
boost
|
|
libiconv
|
|
libintl
|
|
] ++ lib.optionals withData [
|
|
poppler_data
|
|
];
|
|
|
|
# TODO: reduce propagation to necessary libs
|
|
propagatedBuildInputs = [
|
|
zlib
|
|
freetype
|
|
fontconfig
|
|
libjpeg
|
|
openjpeg
|
|
] ++ lib.optionals (!minimal) [
|
|
cairo
|
|
lcms
|
|
curl
|
|
nss
|
|
] ++ lib.optionals (qt5Support || qt6Support) [
|
|
qtbase
|
|
] ++ lib.optionals introspectionSupport [
|
|
gobject-introspection
|
|
] ++ lib.optionals gpgmeSupport [
|
|
gpgme
|
|
];
|
|
|
|
cmakeFlags = [
|
|
(mkFlag true "UNSTABLE_API_ABI_HEADERS") # previously "XPDF_HEADERS"
|
|
(mkFlag (!minimal) "GLIB")
|
|
(mkFlag (!minimal) "CPP")
|
|
(mkFlag (!minimal) "LIBCURL")
|
|
(mkFlag (!minimal) "LCMS")
|
|
(mkFlag (!minimal) "LIBTIFF")
|
|
(mkFlag (!minimal) "NSS3")
|
|
(mkFlag utils "UTILS")
|
|
(mkFlag qt5Support "QT5")
|
|
(mkFlag qt6Support "QT6")
|
|
(mkFlag gpgmeSupport "GPGME")
|
|
] ++ lib.optionals finalAttrs.finalPackage.doCheck [
|
|
"-DTESTDATADIR=${testData}"
|
|
];
|
|
disallowedReferences = lib.optional finalAttrs.finalPackage.doCheck testData;
|
|
|
|
dontWrapQtApps = true;
|
|
|
|
# Workaround #54606
|
|
preConfigure = lib.optionalString stdenv.hostPlatform.isDarwin ''
|
|
sed -i -e '1i cmake_policy(SET CMP0025 NEW)' CMakeLists.txt
|
|
'';
|
|
|
|
# Work around gpgme trying to write to $HOME during qt5 and qt6 tests:
|
|
preCheck = lib.optionalString gpgmeSupport ''
|
|
HOME_orig="$HOME"
|
|
export HOME="$(mktemp -d)"
|
|
'';
|
|
|
|
postCheck = lib.optionalString gpgmeSupport ''
|
|
export HOME="$HOME_orig"
|
|
unset -v HOME_orig
|
|
'';
|
|
|
|
doCheck = true;
|
|
|
|
passthru = {
|
|
inherit testData;
|
|
tests = {
|
|
# These depend on internal poppler code that frequently changes.
|
|
inherit
|
|
cups-filters
|
|
inkscape
|
|
scribus
|
|
;
|
|
|
|
inherit
|
|
gegl
|
|
pdfslicer
|
|
vips
|
|
;
|
|
gdal = gdal.override { usePoppler = true; };
|
|
python-poppler-qt5 = python3.pkgs.poppler-qt5;
|
|
};
|
|
};
|
|
|
|
meta = with lib; {
|
|
homepage = "https://poppler.freedesktop.org/";
|
|
changelog = "https://gitlab.freedesktop.org/poppler/poppler/-/blob/poppler-${version}/NEWS";
|
|
description = "PDF rendering library";
|
|
longDescription = ''
|
|
Poppler is a PDF rendering library based on the xpdf-3.0 code base. In
|
|
addition it provides a number of tools that can be installed separately.
|
|
'';
|
|
license = licenses.gpl2Plus;
|
|
platforms = platforms.all;
|
|
maintainers = with maintainers; [ ttuegel ] ++ teams.freedesktop.members;
|
|
};
|
|
})
|