mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-10-20 11:11:43 -04:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
83 lines
1.6 KiB
Nix
83 lines
1.6 KiB
Nix
{ lib, stdenv
|
|
, fetchFromGitHub
|
|
|
|
, cmake
|
|
, gettext
|
|
, wrapGAppsHook3
|
|
, pkg-config
|
|
|
|
, adwaita-icon-theme
|
|
, alsa-lib
|
|
, binutils
|
|
, glib
|
|
, gsettings-desktop-schemas
|
|
, gtk3
|
|
, gtksourceview4
|
|
, librsvg
|
|
, libsndfile
|
|
, libxml2
|
|
, libzip
|
|
, pcre
|
|
, poppler
|
|
, portaudio
|
|
, zlib
|
|
# plugins
|
|
, withLua ? true, lua
|
|
}:
|
|
|
|
stdenv.mkDerivation rec {
|
|
pname = "xournalpp";
|
|
version = "1.2.3";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "xournalpp";
|
|
repo = "xournalpp";
|
|
rev = "v${version}";
|
|
sha256 = "sha256-8UAAX/kixqiY9zEYs5eva0G2K2vlfnYd1yyVHMSfSeY=";
|
|
};
|
|
|
|
postPatch = ''
|
|
substituteInPlace src/util/Stacktrace.cpp \
|
|
--replace-fail "addr2line" "${binutils}/bin/addr2line"
|
|
'';
|
|
|
|
nativeBuildInputs = [ cmake gettext pkg-config wrapGAppsHook3 ];
|
|
|
|
buildInputs =
|
|
lib.optionals stdenv.hostPlatform.isLinux [
|
|
alsa-lib
|
|
] ++ [
|
|
glib
|
|
gsettings-desktop-schemas
|
|
gtk3
|
|
gtksourceview4
|
|
librsvg
|
|
libsndfile
|
|
libxml2
|
|
libzip
|
|
pcre
|
|
poppler
|
|
portaudio
|
|
zlib
|
|
]
|
|
++ lib.optional withLua lua;
|
|
|
|
buildFlags = [ "translations" ];
|
|
|
|
preFixup = ''
|
|
gappsWrapperArgs+=(
|
|
--prefix XDG_DATA_DIRS : "${adwaita-icon-theme}/share"
|
|
)
|
|
'';
|
|
|
|
meta = with lib; {
|
|
description = "Xournal++ is a handwriting Notetaking software with PDF annotation support";
|
|
homepage = "https://xournalpp.github.io/";
|
|
changelog = "https://github.com/xournalpp/xournalpp/blob/v${version}/CHANGELOG.md";
|
|
license = licenses.gpl2Plus;
|
|
maintainers = with maintainers; [ sikmir ];
|
|
platforms = platforms.unix;
|
|
mainProgram = "xournalpp";
|
|
};
|
|
}
|