mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-10-20 11:11:43 -04:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
77 lines
2.3 KiB
Nix
77 lines
2.3 KiB
Nix
{ lib, stdenv, fetchFromGitHub, substituteAll, jam, cctools, pkg-config
|
|
, SDL, SDL_mixer, SDL_sound, gtk2, libvorbis, smpeg }:
|
|
|
|
let
|
|
|
|
jamenv = ''
|
|
unset AR
|
|
'' + (if stdenv.hostPlatform.isDarwin then ''
|
|
export NIX_CFLAGS_COMPILE="$NIX_CFLAGS_COMPILE -I${lib.getDev SDL}/include/SDL"
|
|
export GARGLKINI="$out/Applications/Gargoyle.app/Contents/Resources/garglk.ini"
|
|
'' else ''
|
|
export NIX_LDFLAGS="$NIX_LDFLAGS -rpath $out/libexec/gargoyle"
|
|
export DESTDIR="$out"
|
|
export _BINDIR=libexec/gargoyle
|
|
export _APPDIR=libexec/gargoyle
|
|
export _LIBDIR=libexec/gargoyle
|
|
export GARGLKINI="$out/etc/garglk.ini"
|
|
'');
|
|
|
|
in
|
|
|
|
stdenv.mkDerivation rec {
|
|
pname = "gargoyle";
|
|
version = "2019.1.1";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "garglk";
|
|
repo = "garglk";
|
|
rev = version;
|
|
sha256 = "0w54avmbp4i4zps2rb4acmpa641s6wvwbrln4vbdhcz97fx48nzz";
|
|
};
|
|
|
|
nativeBuildInputs = [ jam pkg-config ] ++ lib.optional stdenv.hostPlatform.isDarwin cctools;
|
|
|
|
buildInputs = [ SDL SDL_mixer SDL_sound gtk2 ]
|
|
++ lib.optionals stdenv.hostPlatform.isDarwin [ smpeg libvorbis ];
|
|
|
|
# Workaround build failure on -fno-common toolchains:
|
|
# ld: build/linux.release/alan3/Location.o:(.bss+0x0): multiple definition of
|
|
# `logFile'; build/linux.release/alan3/act.o:(.bss+0x0): first defined here
|
|
# TODO: drop once updated to 2022.1 or later.
|
|
env.NIX_CFLAGS_COMPILE = "-fcommon";
|
|
|
|
buildPhase = jamenv + "jam -j$NIX_BUILD_CORES";
|
|
|
|
installPhase =
|
|
if stdenv.hostPlatform.isDarwin then
|
|
(substituteAll {
|
|
inherit (stdenv) shell;
|
|
isExecutable = true;
|
|
src = ./darwin.sh;
|
|
})
|
|
else jamenv + ''
|
|
jam -j$NIX_BUILD_CORES install
|
|
mkdir -p "$out/bin"
|
|
ln -s ../libexec/gargoyle/gargoyle "$out/bin"
|
|
mkdir -p "$out/etc"
|
|
cp garglk/garglk.ini "$out/etc"
|
|
mkdir -p "$out/share/applications"
|
|
cp garglk/gargoyle.desktop "$out/share/applications"
|
|
mkdir -p "$out/share/icons/hicolor/32x32/apps"
|
|
cp garglk/gargoyle-house.png "$out/share/icons/hicolor/32x32/apps"
|
|
'';
|
|
|
|
enableParallelBuilding = true;
|
|
|
|
meta = with lib; {
|
|
broken = stdenv.hostPlatform.isDarwin;
|
|
homepage = "http://ccxvii.net/gargoyle/";
|
|
license = licenses.gpl2Plus;
|
|
description = "Interactive fiction interpreter GUI";
|
|
mainProgram = "gargoyle";
|
|
platforms = platforms.unix;
|
|
maintainers = with maintainers; [ orivej ];
|
|
};
|
|
}
|