2020-04-27 03:31:39 -04:00
<!--
To help with the large amounts of pull requests, we would appreciate your
reviews of other pull requests, especially simple package updates. Just leave a
comment describing what you have tested in the relevant package/service.
Reviewing helps to reduce the average time-to-merge for everyone.
Thanks a lot if you do!
List of open PRs: https://github.com/NixOS/nixpkgs/pulls
2020-11-13 19:18:19 -05:00
Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions
2020-04-27 03:31:39 -04:00
-->
2016-05-24 07:59:46 -04:00
###### Motivation for this change
2016-04-09 12:53:24 -04:00
###### Things done
2016-02-28 04:26:21 -05:00
2017-08-12 10:17:39 -04:00
<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->
2017-07-22 12:04:19 -04:00
2016-03-16 04:46:05 -04:00
- Built on platform(s)
2021-08-14 07:39:46 -04:00
- [ ] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
2021-11-19 20:07:02 -05:00
- [ ] For non-Linux: Is `sandbox = true` set in `nix.conf` ? (See [Nix manual ](https://nixos.org/manual/nix/stable/command-ref/conf-file.html ))
2021-10-31 15:56:30 -04:00
- [ ] Tested, as applicable:
2021-11-03 13:16:41 -04:00
- [NixOS test(s) ](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests ) (look inside [nixos/tests ](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests ))
- and/or [package tests ](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests )
- or, for functions and "core" functionality, tests in [lib/tests ](https://github.com/NixOS/nixpkgs/blob/master/lib/tests ) or [pkgs/test ](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test )
- made sure NixOS tests are [linked ](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking ) to the relevant packages
2021-11-10 12:24:34 -05:00
- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"` . Note: all changes have to be committed, also see [nixpkgs-review usage ](https://github.com/Mic92/nixpkgs-review#usage )
2021-10-31 19:15:21 -04:00
- [ ] Tested basic functionality of all binary files (usually in `./result/bin/` )
2021-11-30 00:20:21 -05:00
- [22.05 Release Notes (or backporting 21.11 Release notes) ](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2205-release-notes )
2021-06-02 16:21:56 -04:00
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
2021-10-15 19:26:47 -04:00
- [ ] (Release notes changes) Ran `nixos/doc/manual/md-to-db.sh` to update generated release notes
2021-06-25 22:37:39 -04:00
- [ ] Fits [CONTRIBUTING.md ](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md ).