mirror of
https://github.com/open-goal/jak-project.git
synced 2024-10-20 11:26:18 -04:00
c162c66118
This PR does two main things: 1. Work through the main low-hanging fruit issues in the formatter keeping it from feeling mature and usable 2. Iterate and prove that point by formatting all of the Jak 1 code base. **This has removed around 100K lines in total.** - The decompiler will now format it's results for jak 1 to keep things from drifting back to where they were. This is controlled by a new config flag `format_code`. How am I confident this hasn't broken anything?: - I compiled the entire project and stored it's `out/jak1/obj` files separately - I then recompiled the project after formatting and wrote a script that md5's each file and compares it (`compare-compilation-outputs.py` - The results (eventually) were the same:  > This proves that the only difference before and after is non-critical whitespace for all code/macros that is actually in use. I'm still aware of improvements that could be made to the formatter, as well as general optimization of it's performance. But in general these are for rare or non-critical situations in my opinion and I'll work through them before doing Jak 2. The vast majority looks great and is working properly at this point. Those known issues are the following if you are curious: 
48 lines
1.6 KiB
Common Lisp
48 lines
1.6 KiB
Common Lisp
===
|
|
With behavior tag
|
|
===
|
|
|
|
(lambda :behavior
|
|
target
|
|
()
|
|
(println "something"))
|
|
|
|
---
|
|
|
|
(lambda :behavior target ()
|
|
(println "something"))
|
|
|
|
===
|
|
Without behavior tag
|
|
===
|
|
|
|
(lambda ()
|
|
(println "something"))
|
|
|
|
---
|
|
|
|
(lambda ()
|
|
(println "something"))
|
|
|
|
===
|
|
Too long
|
|
===
|
|
|
|
(lambda ((arg0 part-tracker))
|
|
(let ((s5-0 (handle->process (-> arg0 userdata)))) (when s5-0 (let* ((v1-4 (handle->process (-> (the-as eco-collectable s5-0) pickup-handle))) (a2-0 (cond ((not v1-4) (-> arg0 root trans)) ((= (-> v1-4 type) target) (vector<-cspace! (new 'stack-no-clear 'vector) (-> (the-as target v1-4) node-list data 5))) (else (-> (the-as target v1-4) control trans))))) (vector-lerp! (-> arg0 root trans) (-> arg0 offset) a2-0 (/ (the float (- (current-time) (-> arg0 start-time))) (the float (-> (the-as eco-collectable s5-0) collect-effect-time))))))))
|
|
|
|
---
|
|
|
|
(lambda ((arg0 part-tracker))
|
|
(let ((s5-0 (handle->process (-> arg0 userdata))))
|
|
(when s5-0
|
|
(let* ((v1-4 (handle->process (-> (the-as eco-collectable s5-0) pickup-handle)))
|
|
(a2-0 (cond
|
|
((not v1-4) (-> arg0 root trans))
|
|
((= (-> v1-4 type) target) (vector<-cspace! (new 'stack-no-clear 'vector) (-> (the-as target v1-4) node-list data 5)))
|
|
(else (-> (the-as target v1-4) control trans)))))
|
|
(vector-lerp! (-> arg0 root trans)
|
|
(-> arg0 offset)
|
|
a2-0
|
|
(/ (the float (- (current-time) (-> arg0 start-time)))
|
|
(the float (-> (the-as eco-collectable s5-0) collect-effect-time)))))))) |