jak-project/common/goos
water111 d5951c2b11
[jak 2] Fix possible stereo desync in overlord (#2663)
Normally, when they allocate a VagCmd, they do a bunch of stuff to clear
all the status bits and reset things
in particular the InitVAGCmd function does a lot


![image](https://github.com/open-goal/jak-project/assets/48171810/9b355020-ad37-496c-9438-2f8d34f24e0a)

but for the stereo command, they do a lot less:

![image](https://github.com/open-goal/jak-project/assets/48171810/12a36712-0e68-4377-a6be-3bde82c2aa15)

Which means that the new_stereo_command can just have random status bits
left over from whatever the last user had.
we seem to end up in a state where byte21 is set, and this causes
everything else to be wrong and off-by-one dma transfer. My guess is
that the original game avoided this bug due to lucky timing that I don't
understand.

I think the fix of just clearing byte21 is ok because there's no way
that the old value of the byte is useful after the command is
repurposed.
2023-05-19 21:17:11 -04:00
..
Interpreter.cpp [jak2] try to speed up compile a bit (#2596) 2023-04-30 14:13:52 -04:00
Interpreter.h allow quoting :key symbols + further optimize defpart (#2592) 2023-04-30 02:46:14 +01:00
Object.cpp [jak2] try to speed up compile a bit (#2596) 2023-04-30 14:13:52 -04:00
Object.h less branches for division + fix divide by zeros (#2585) 2023-04-29 21:10:51 +01:00
ParseHelpers.cpp [jak 2] Fix possible stereo desync in overlord (#2663) 2023-05-19 21:17:11 -04:00
ParseHelpers.h [jak 2] Fix possible stereo desync in overlord (#2663) 2023-05-19 21:17:11 -04:00
PrettyPrinter.cpp logs: replace every fmt::print with a lg call instead (#1368) 2022-10-01 11:58:36 -04:00
PrettyPrinter.h lint: add include sorting config to clang-format (#1517) 2022-06-22 23:37:46 -04:00
PrettyPrinter2.cpp start blit-displays decomp & renderer + improve decompilation of some DMA macros (#2616) 2023-05-04 18:34:09 -04:00
PrettyPrinter2.h lint: add include sorting config to clang-format (#1517) 2022-06-22 23:37:46 -04:00
Printer.cpp [decomp] collectables, fix float bug in a few files (#2082) 2023-01-01 18:05:31 -05:00
Printer.h d/jak2: mostly finish mysql-nav-graph and fix docstring handling around with-pp/local-vars (#1869) 2022-09-13 18:15:02 -04:00
Reader.cpp goalc/repl: cleanup of goalc/REPL code and some QoL improvements (#2104) 2023-01-07 11:24:02 -05:00
Reader.h goalc/repl: cleanup of goalc/REPL code and some QoL improvements (#2104) 2023-01-07 11:24:02 -05:00
TextDB.cpp [goalc] reduce compiler memory usage (#2247) 2023-02-24 18:32:30 -05:00
TextDB.h [goalc] reduce compiler memory usage (#2247) 2023-02-24 18:32:30 -05:00