jak-project/game/graphics/opengl_renderer/dma_helpers.cpp
Tyler Wilding 4d751af38e
logs: replace every fmt::print with a lg call instead (#1368)
Favors the `lg` namespace over `fmt` directly, as this will output the
logs to a file / has log levels.

I also made assertion errors go to a file, this unfortunately means
importing `lg` and hence `fmt` which was attempted to be avoided before.
But I'm not sure how else to do this aspect without re-inventing the
file logging.

We have a lot of commented out prints as well that we should probably
cleanup at some point / switch them to trace level and default to `info`
level.

I noticed the pattern of disabling debug logs behind some boolean,
something to consider cleaning up in the future -- if our logs were more
structured (knowing where they are coming from) then a lot this
boilerplate could be eliminated.

Closes #1358
2022-10-01 11:58:36 -04:00

140 lines
4.3 KiB
C++

#include "dma_helpers.h"
#include "common/log/log.h"
#include "third-party/fmt/format.h"
/*!
* Make sure that the DMA Transfer is a VIF unpack (copy data to VIF memory) with the given
* setup. This is for a transfer with STCYCL followed by UNPACK.
*/
bool verify_unpack_with_stcycl(const DmaTransfer& transfer,
VifCode::Kind unpack_kind,
u16 cl,
u16 wl,
u32 qwc,
u32 addr,
bool usn,
bool flg) {
if (transfer.size_bytes != qwc * 16) {
lg::error("verify_unpack: bad size {} vs {}", transfer.size_bytes, qwc * 16);
return false;
}
if (transfer.vifcode0().kind != VifCode::Kind::STCYCL) {
lg::error("verify_unpack: bad vifcode 0");
return false;
}
if (transfer.vifcode1().kind != unpack_kind) {
lg::error("verify_unpack: bad vifcode 1");
return false;
}
VifCodeStcycl stcycl(transfer.vifcode0());
VifCodeUnpack unpack(transfer.vifcode1());
if (stcycl.cl != cl || stcycl.wl != wl) {
lg::error("verify_unpack: bad cl/wl {}/{} vs {}/{}", stcycl.cl, stcycl.wl, cl, wl);
return false;
}
if (unpack.addr_qw != addr || unpack.use_tops_flag != flg || unpack.is_unsigned != usn) {
lg::error("verify_unpack: bad unpack {}/{}/{} vs {}/{}/{}", unpack.addr_qw,
unpack.use_tops_flag, unpack.is_unsigned, addr, flg, usn);
return false;
}
if (transfer.vifcode1().num != qwc) {
lg::error("verify_unpack: bad num {} vs {}", transfer.vifcode1().num, qwc);
return false;
}
return true;
}
/*!
* Verify the DMA transfer is a VIF unpack (with STCYCL tag).
* Then, unpack the data to dst.
*/
void unpack_to_stcycl(void* dst,
const DmaTransfer& transfer,
VifCode::Kind unpack_kind,
u16 cl,
u16 wl,
u32 size_bytes,
u32 addr,
bool usn,
bool flg) {
bool ok =
verify_unpack_with_stcycl(transfer, unpack_kind, cl, wl, size_bytes / 16, addr, usn, flg);
ASSERT(ok);
ASSERT((size_bytes & 0xf) == 0);
memcpy(dst, transfer.data, size_bytes);
}
/*!
* Make sure that the DMA transfer is a VIF unpack with the given setup.
* This is for when there's just an UNPACK.
*/
bool verify_unpack_no_stcycl(const DmaTransfer& transfer,
VifCode::Kind unpack_kind,
u32 qwc,
u32 addr,
bool usn,
bool flg) {
if (transfer.size_bytes != qwc * 16) {
lg::error("verify_unpack: bad size {} vs {}", transfer.size_bytes, qwc * 16);
return false;
}
if (transfer.vifcode0().kind != VifCode::Kind::NOP) {
lg::error("verify_unpack: bad vifcode 0");
return false;
}
if (transfer.vifcode1().kind != unpack_kind) {
lg::error("verify_unpack: bad vifcode 1");
return false;
}
VifCodeUnpack unpack(transfer.vifcode1());
if (unpack.addr_qw != addr || unpack.use_tops_flag != flg || unpack.is_unsigned != usn) {
lg::error("verify_unpack: bad unpack {}/{}/{} vs {}/{}/{}", unpack.addr_qw,
unpack.use_tops_flag, unpack.is_unsigned, addr, flg, usn);
return false;
}
if (transfer.vifcode1().num != qwc) {
lg::error("verify_unpack: bad num {} vs {}", transfer.vifcode1().num, qwc);
return false;
}
return true;
}
/*!
* Verify the DMA transfer is a VIF unpack (with no STCYCL tag).
* Then, unpack the data to dst.
*/
void unpack_to_no_stcycl(void* dst,
const DmaTransfer& transfer,
VifCode::Kind unpack_kind,
u32 size_bytes,
u32 addr,
bool usn,
bool flg) {
bool ok = verify_unpack_no_stcycl(transfer, unpack_kind, size_bytes / 16, addr, usn, flg);
ASSERT(ok);
ASSERT((size_bytes & 0xf) == 0);
memcpy(dst, transfer.data, size_bytes);
}
void verify_mscal(const DmaTransfer& transfer, int address) {
ASSERT(transfer.size_bytes == 0);
ASSERT(transfer.vif0() == 0);
ASSERT(transfer.vifcode1().kind == VifCode::Kind::MSCAL);
ASSERT(transfer.vifcode1().immediate == address);
}